Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on close pane when the command pallete is open #6348

Open
ElykDeer opened this issue Jan 22, 2025 · 3 comments
Open

Crash on close pane when the command pallete is open #6348

ElykDeer opened this issue Jan 22, 2025 · 3 comments
Labels
Component: UI Issue needs changes to the user interface Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround Type: Crash Issue is a crash or deadlock UI: Command Palette Issues with the Command Palette UI: Panes Issues with the Pane system

Comments

@ElykDeer
Copy link
Member

ElykDeer commented Jan 22, 2025

Version and Platform (required):

  • Binary Ninja Version: 4.2.6703-dev
  • OS: MacOS
  • OS Version: 15.2
  • CPU Architecture: M2

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

  1. Open a binary
  2. Split open a new pane
  3. Command-P
  4. Command-Option-W (close pane)
  5. Observe crash

I only really noticed this because I rebound command-w to close panes instead of tabs. Triggering close pane through the command palette doesn't trigger the crash.

@ElykDeer ElykDeer added Component: UI Issue needs changes to the user interface Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround Type: Crash Issue is a crash or deadlock UI: Command Palette Issues with the Command Palette UI: Panes Issues with the Pane system labels Jan 22, 2025
@plafosse
Copy link
Member

plafosse commented Feb 4, 2025

@ElykDeer I can't reproduce this can you ensure this isn't a local problem?

@plafosse plafosse added the State: Unreproducible Issue could not be reproduced by a developer label Feb 4, 2025
@ElykDeer
Copy link
Member Author

ElykDeer commented Feb 4, 2025

I can confirm I was able to reproduce this on a fresh install in Windows with 4.3.6799-dev. Also reproduces on Mac on 4.3.6799-dev_ultimate. See wiggle worth waive water in Slack for crash dumps.

@xusheng6
Copy link
Member

xusheng6 commented Feb 5, 2025

I can get a repro now. In fact I already get the repro yesterday, since after step 4 the binja window disappears. However, I just thought is was normal since I was closing since (the crash report dialog shows up quite a few moments later and I ignore that)

@xusheng6 xusheng6 changed the title Crash on close pane Crash on close pane when the command pallete is open Feb 5, 2025
@psifertex psifertex removed the State: Unreproducible Issue could not be reproduced by a developer label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: UI Issue needs changes to the user interface Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround Type: Crash Issue is a crash or deadlock UI: Command Palette Issues with the Command Palette UI: Panes Issues with the Pane system
Projects
None yet
Development

No branches or pull requests

4 participants