Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading an older database to Enterprise causes database upgrade message twice #6355

Open
fuzyll opened this issue Jan 23, 2025 · 0 comments
Labels
Component: UI Issue needs changes to the user interface Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround Type: Bug Issue is a non-crashing bug with repro steps UI: Dialogs Issues with smaller dialogs

Comments

@fuzyll
Copy link
Contributor

fuzyll commented Jan 23, 2025

Version and Platform (required):

  • Binary Ninja Version: 4.3.6703-dev
  • OS: macOS
  • OS Version: 15.2
  • CPU Architecture: aarch64

Bug Description:
If you upload an old database to an Enterprise project, you will be asked to upgrade the database twice, since the first time (the actual upload) doesn't appear to actually trigger the database upgrade.

Steps To Reproduce:

  1. Open up an Enterprise project (must be connected to the server for this to work)
  2. Drag-and-drop an old .bndb into the project
  3. Observe that the database will start automatically uploading and show you the dialog for upgrading the database (choose "Yes").
  4. Once it has finished uploading, double-click the database to open it
  5. Observe that you will be shown the dialog again asking you to upgrade the database (choose "Yes").
  6. Bonus points: Don't save, close it, open it again and observe the same dialog over and over.

Expected Behavior:
If we don't automatically perform the upgrade and prevent using it on older versions like the dialog says, I'm actually fine with that? We should just move the logic for when the dialog is displayed to be before the actual save occurs. Otherwise, something else is maybe going wrong here, because the dialog suggests clicking "Yes" should cause the upgrade to happen immediately and be saved.

Screenshots/Video Recording:

Image

Binary:
Databases and project available upon request.

@fuzyll fuzyll added Component: UI Issue needs changes to the user interface Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround Type: Bug Issue is a non-crashing bug with repro steps UI: Dialogs Issues with smaller dialogs labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: UI Issue needs changes to the user interface Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround Type: Bug Issue is a non-crashing bug with repro steps UI: Dialogs Issues with smaller dialogs
Projects
None yet
Development

No branches or pull requests

1 participant