Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large BNDBs result in unusably slow UI, 10+ second freezes #6356

Open
yrp604 opened this issue Jan 23, 2025 · 5 comments
Open

Large BNDBs result in unusably slow UI, 10+ second freezes #6356

yrp604 opened this issue Jan 23, 2025 · 5 comments
Assignees
Labels
Component: UI Issue needs changes to the user interface Effort: Medium Issue should take < 1 month Impact: High Issue adds or blocks important functionality Type: Performance Issue causes UI hangs or is overly slow UI: Cross References Issues with the Cross References widget
Milestone

Comments

@yrp604
Copy link
Contributor

yrp604 commented Jan 23, 2025

Version and Platform (required):

  • Binary Ninja Version: 6725
  • OS: Windows
  • OS Version: 11
  • CPU Architecture: [e.g. x64 or M1]x64

Bug Description:
10+ second lag spikes when performing normal operations :(

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

  1. Click on a common type with a lot of xrefs
  2. click somewhere else

Expected Behavior:
zoom zoom

Binary:
privately provided to v35

@galenbwill
Copy link
Contributor

Define "large"?

@emesare
Copy link
Member

emesare commented Jan 23, 2025

This might be the same as what @WeiN76LQh described here #6301 (comment)

@WeiN76LQh
Copy link

Yes sounds exactly the same, clicking around on the linear view or types (and potentially other places) causing the xrefs UI to update seems to be still problematic when theres lots, like 10,000+, which is common in container types like DYLD Shared Cache. It seems a lock is causing the UI to freeze.

@fuzyll
Copy link
Contributor

fuzyll commented Jan 23, 2025

Peter has been working on this in the past week. Some of the performance impact is related to #6301, but not all. Part of the original report has been addressed, but there is still additional work to be done.

V35 employees can search for trash easel provided punctured to find the file.

@emesare emesare added State: Awaiting Triage Issue is waiting for more in-depth triage from a developer UI: Cross References Issues with the Cross References widget labels Jan 25, 2025
@plafosse
Copy link
Member

plafosse commented Feb 4, 2025

There has been significant progress on this and we will continue to make additional progress for this release. As of now its not perfect and if you select something that has millions of xrefs you'll likely still experience a brief hang, but it should no longer lock up the UI for minutes/hours

@plafosse plafosse self-assigned this Feb 4, 2025
@plafosse plafosse added Impact: High Issue adds or blocks important functionality Effort: Medium Issue should take < 1 month labels Feb 4, 2025
@fuzyll fuzyll added Component: UI Issue needs changes to the user interface Type: Performance Issue causes UI hangs or is overly slow and removed State: Awaiting Triage Issue is waiting for more in-depth triage from a developer labels Feb 8, 2025
@fuzyll fuzyll added this to the Gallifrey milestone Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: UI Issue needs changes to the user interface Effort: Medium Issue should take < 1 month Impact: High Issue adds or blocks important functionality Type: Performance Issue causes UI hangs or is overly slow UI: Cross References Issues with the Cross References widget
Projects
None yet
Development

No branches or pull requests

6 participants