Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when loading specific ELF file with DWARF info #6385

Closed
1337-42 opened this issue Feb 3, 2025 · 3 comments
Closed

Crash when loading specific ELF file with DWARF info #6385

1337-42 opened this issue Feb 3, 2025 · 3 comments
Assignees
@emesare
Labels
Component: DebugInfo Issue requires changes to the DebugInfo API DebugInfo: DWARF Effort: Trivial Issue should take < 1 day Impact: Medium Issue is impactful with a bad, or no, workaround
Milestone
Gallifrey

Comments

@1337-42
Copy link

1337-42 commented Feb 3, 2025

Version and Platform (required):

  • Binary Ninja Version: 4.3.6791 and 4.2.6455
  • OS: MacOS and Linux
  • CPU Architecture: x64 and M1

Bug Description:
When opening the attached file libiso.so.0.0.0.tar.gz BN will crash while loading the DWARF info.

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

  1. Open the attached file.

Expected Behavior:
Bn Should load the file, including the debug info.

Binary:
The binary is attached to the issue.

Additional Information:
Tested on both Mac and Linux, both on x86 and ARM/M1 hardware.
@negasora negasora self-assigned this Feb 3, 2025
@negasora negasora added the State: Awaiting Triage Issue is waiting for more in-depth triage from a developer label Feb 3, 2025
@emesare
Copy link
Member

emesare commented Feb 3, 2025

Looks like there is a function type with a param of that function type, causing infinite recursion.

@negasora negasora assigned emesare and unassigned negasora Feb 3, 2025
@emesare
Copy link
Member

emesare commented Feb 4, 2025

api-12-57-58 PM.patch

I think this is probably fine? I don't see any immediately incorrect functions. I am going to wait for @negasora to thumbs up this fix before merging.

@emesare emesare added Impact: Medium Issue is impactful with a bad, or no, workaround Effort: Trivial Issue should take < 1 day DebugInfo: DWARF Component: DebugInfo Issue requires changes to the DebugInfo API and removed State: Awaiting Triage Issue is waiting for more in-depth triage from a developer labels Feb 4, 2025
@fuzyll
Copy link
Contributor

fuzyll commented Feb 5, 2025

The fix above should be included in builds >= 4.3.6802-dev. Thanks for the report!

@fuzyll fuzyll closed this as completed Feb 5, 2025
@fuzyll fuzyll added this to the Gallifrey milestone Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emesare emesare

Labels
Component: DebugInfo Issue requires changes to the DebugInfo API DebugInfo: DWARF Effort: Trivial Issue should take < 1 day Impact: Medium Issue is impactful with a bad, or no, workaround
Projects
None yet
Milestone
Gallifrey
Development

No branches or pull requests
4 participants
@fuzyll @negasora @emesare @1337-42