[Bug] TypingIndicator: User popout unrenders, even when focused, after all users stop typing

[sadan4]

Discord Account

No response

What happens when the bug or crash occurs?

the user popout profile vanishes even if it was in use

What is the expected behaviour?

i expect clicking the users avatar to do nothing or for the popout to stay even after all users have stopped typing

How do you recreate this bug or crash?

1. click on a users avatar in a typing indicator
2. start doing something on their profile
3. they stop typing and there are no other users in the channel typing
4. the popout vanished even if it was still focused/hovered

Errors

N/A

Request Agreement

• I am using Discord Stable or tried on Stable and this bug happens there as well
• I have read the requirements for opening an issue above

[Sqaaakoi]

this would probably require reimplementing a small portion of UserSummaryItem
it actually doesn't seem quite hard to do tbh

maybe we could just patch the component?

edit: @Nuckyz has made me look at the surrounding code in the plugin and it's not as simple as that

[Sqaaakoi]

forget all of that. I have a working prototype now.

How it works:
remove the if (typingUsersArray.length > 0) condition so the component always renders
add that condition to the Dots indicator mode condition

[Sqaaakoi]

MY GLORIOUS HORRORCODE

    // if (typingUsersArray.length > 0) {
    return (
        <Tooltip text={tooltipText!}>
            {props => (
                <div className="vc-typing-indicator" {...props}>
                    {((settings.store.indicatorMode & IndicatorMode.Avatars) === IndicatorMode.Avatars) && (
                        <div
                            onClick={e => {
                                e.stopPropagation();
                                e.preventDefault();
                            }}
                            onKeyPress={e => e.stopPropagation()}
                        >
                            <UserSummaryItem
                                users={typingUsersArray.map(id => UserStore.getUser(id))}
                                guildId={guildId}
                                renderIcon={false}
                                max={3}
                                showDefaultAvatarsForNullUsers
                                showUserPopout
                                size={16}
                                className={typingUsersArray.length > 0 ? "vc-typing-indicator-avatars" : ""}
                            />
                        </div>
                    )}
                    {((settings.store.indicatorMode & IndicatorMode.Dots) === IndicatorMode.Dots) && typingUsersArray.length > 0 && (
                        <div className="vc-typing-indicator-dots">
                            <ThreeDots dotRadius={3} themed={true} />
                        </div>
                    )}
                </div>
            )}
        </Tooltip>
    );
    // }

    return null;
}