Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-2042]: add info about the DefaultProxyAdmin used in testnet #311

Merged
merged 1 commit into from
Oct 10, 2023
Merged

[VEN-2042]: add info about the DefaultProxyAdmin used in testnet #311

merged 1 commit into from
Oct 10, 2023

Conversation

chechu
Copy link
Member

@chechu chechu commented Oct 10, 2023

Description

Resolves VEN-2042

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@chechu chechu requested a review from web3rover October 10, 2023 15:24
@chechu chechu self-assigned this Oct 10, 2023
web3rover
web3rover previously approved these changes Oct 10, 2023
View reviewed changes
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
contracts 96% 76% ✔
contracts.Lens 95% 65% ✔
contracts.Pool 100% 92% ✔
contracts.Rewards 95% 62% ✔
contracts.RiskFund 99% 71% ✔
contracts.Shortfall 100% 85% ✔
contracts.lib 100% 89% ✔
Summary 97% (1454 / 1504) 75% (442 / 590) ✔

@chechu chechu merged commit 14a7535 into develop Oct 10, 2023
3 checks passed
@chechu chechu deleted the feat/VEN-2042 branch November 29, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web3rover web3rover web3rover approved these changes

Assignees

@chechu chechu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chechu @web3rover