Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-2923] Add eBTC Market #450

Merged
merged 12 commits into from
Nov 8, 2024
Merged

[VEN-2923] Add eBTC Market #450

merged 12 commits into from
Nov 8, 2024

Conversation

web3rover
Copy link
Collaborator

Description

Resolves #

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@web3rover web3rover self-assigned this Oct 30, 2024
@web3rover web3rover marked this pull request as ready for review October 30, 2024 13:36
chechu
chechu reviewed Oct 30, 2024
View reviewed changes
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
@web3rover @chechu
fix: remove duplicate config
fd58eb0 
Co-authored-by: Jesus Lanchas <[email protected]>
chechu
chechu reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@chechu chechu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sepolia deployment lgtm

chechu
chechu previously approved these changes Nov 7, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

Code Coverage

Package Line Rate Branch Rate Health
contracts 94% 76% ✔
contracts.Gateway 98% 68% ✔
contracts.Gateway.Interfaces 100% 100% ✔
contracts.Lens 95% 71% ✔
contracts.Lens.legacy 0% 0% ❌
contracts.Pool 100% 92% ✔
contracts.Rewards 96% 70% ✔
contracts.Shortfall 100% 85% ✔
contracts.legacy.RiskFund 0% 0% ❌
contracts.lib 100% 89% ✔
Summary 76% (1557 / 2055) 65% (516 / 798) ➖

@web3rover web3rover merged commit fd01a46 into develop Nov 8, 2024
4 checks passed
@web3rover web3rover deleted the feat/ven-2923 branch November 8, 2024 18:36
@chechu chechu mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chechu chechu chechu approved these changes

Assignees

@web3rover web3rover

Labels
ethereum sepolia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@web3rover @chechu