Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-2968]: Ethena pool on Ethereum #457

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from
Open

[VEN-2968]: Ethena pool on Ethereum #457

wants to merge 20 commits into from

Conversation

GitGuru7
Copy link
Contributor

Description

Resolves #

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@GitGuru7 GitGuru7 self-assigned this Dec 10, 2024
@GitGuru7 GitGuru7 requested a review from chechu December 10, 2024 15:57
@GitGuru7 GitGuru7 marked this pull request as ready for review December 11, 2024 07:04
@GitGuru7 GitGuru7 changed the title [VEN-2698]: Ethena pool on Ethereum [VEN-2968]: Ethena pool on Ethereum Dec 19, 2024
chechu
chechu reviewed Dec 19, 2024
View reviewed changes
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
@chechu chechu mentioned this pull request Dec 19, 2024
Open
4 tasks
chechu
chechu previously approved these changes Dec 19, 2024
View reviewed changes
web3rover
web3rover previously approved these changes Dec 19, 2024
View reviewed changes
@GitGuru7 GitGuru7 dismissed stale reviews from web3rover and chechu via 76f6597 December 20, 2024 14:28
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
contracts 94% 76% ✔
contracts.Gateway 98% 68% ✔
contracts.Gateway.Interfaces 100% 100% ✔
contracts.Lens 95% 71% ✔
contracts.Lens.legacy 0% 0% ❌
contracts.Pool 100% 92% ✔
contracts.Rewards 96% 70% ✔
contracts.Shortfall 100% 85% ✔
contracts.legacy.RiskFund 0% 0% ❌
contracts.lib 100% 89% ✔
Summary 76% (1557 / 2055) 65% (516 / 798) ➖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gleiser-oliveira gleiser-oliveira gleiser-oliveira left review comments

@chechu chechu chechu approved these changes

@web3rover web3rover web3rover left review comments

Assignees

@GitGuru7 GitGuru7

Labels
ethereum sepolia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GitGuru7 @chechu @web3rover @gleiser-oliveira