Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should mata be always built as a static library? #318

Open
jurajsic opened this issue Sep 1, 2023 · 0 comments
Open

Should mata be always built as a static library? #318

jurajsic opened this issue Sep 1, 2023 · 0 comments

Comments

@jurajsic
Copy link
Member

jurajsic commented Sep 1, 2023

Currently we force cmake to build mata as a static library by

add_library(libmata STATIC

If we change it to

add_library(libmata

it should by default still be built as a static library, but if BUILD_SHARED_LIBS is on, it will build a shared library.

Do we want to allow this? It might be better to allow it, if somebody wants to use mata as a shared library, so that they do not need to change the cmake file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant