Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codecov computes base coverage for incorrect commit #323

Open
Adda0 opened this issue Sep 6, 2023 · 0 comments
Open

Codecov computes base coverage for incorrect commit #323

Adda0 opened this issue Sep 6, 2023 · 0 comments
Assignees
@tfiedor @Adda0
Labels
For:devops The issue is related to devops (github actions, compilation, documentation, etc.) Type:required A required implementation/change necessary in near future

Comments

@Adda0
Copy link
Collaborator

Adda0 commented Sep 6, 2023

Codecov compares coverages between the HEAD of the new branch and base branch, but it incorrectly set the commit for the HEAD of the base branch, as seen in, for example, #322. We need to fix the settings, presumably, to correctly compare against the latest commit on the base branch. That is, the current HEAD of the base branch.
@Adda0 Adda0 added For:devops The issue is related to devops (github actions, compilation, documentation, etc.) Type:required A required implementation/change necessary in near future labels Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tfiedor tfiedor

@Adda0 Adda0

Labels
For:devops The issue is related to devops (github actions, compilation, documentation, etc.) Type:required A required implementation/change necessary in near future
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tfiedor @Adda0