Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "saml2aws configure" CLI prompting #1390

Open
ary-b opened this issue Feb 4, 2025 · 1 comment
Open

Improve "saml2aws configure" CLI prompting #1390

ary-b opened this issue Feb 4, 2025 · 1 comment

Comments

@ary-b
Copy link

ary-b commented Feb 4, 2025

TLDR: "Passwords did not match" is solved by entering the password again when prompted "Confirm" rather than pressing "Enter" to confirm.

When running the saml2aws configure command to login with Okta, the user is prompted Confirm after entering the password. This seems like a very unintuitive way to ask the user to input the same password again. It leads user to press "Enter" to confirm their inputs.

The error message "Passwords did not match" also doesn't make it explicit that the entered password and the confirmed one don't match (obviously because there isn't any confirmed password) and leaves the user perplexed, trying to understand which 2 passwords don't match.

Image

This can be very simply solved by changing the "Confirm" wording to something like "Confirm entered password" or "Enter password again", which is exactly what the CLI is trying to make the user do. An alternative would be to change the error message to "Confirmed password doesn't match".

I tried to open a pull request but I don't have the right permissions to do it. I hope this can be considered as a small but considerable improvement. Cheers!

@ary-b ary-b changed the title Improve "Configure CLI" prompting Improve "aws2saml configure" CLI prompting Feb 4, 2025
@ary-b ary-b changed the title Improve "aws2saml configure" CLI prompting Improve "saml2aws configure" CLI prompting Feb 4, 2025
@tayyeb-ali
Copy link

Thanks @ary-b I had the same problem. Very ambiguous prompt for a user input here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants