Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

House Keeping: not all global vars have g_ prepended #23

Open
ElSkunkito opened this issue Nov 15, 2015 · 0 comments
Open

House Keeping: not all global vars have g_ prepended #23

ElSkunkito opened this issue Nov 15, 2015 · 0 comments

Comments

@ElSkunkito
Copy link
Collaborator

For clarity I have prepended g_to what were variables inside of the GC class.
THey are effectively globals in Java script.

Not all of them got the preneded g_.

at the top of gc.ui.js you will see them
var lastcoordsystem = 1; // 1=dd.ddddd, 2=ddmmss.ss, 3=ddmm.mmmm
var sign = 1;
var degrees = 0;
...

THey should all have g_added, and in source have it added as well.

This must be a careful operation as ther is a slight possibility some local vars may share
the same name as the globals.

also determine if and why the var have to be declared at the top of gc.ui.js.
other globals are inside of GC_init() and they work fine.
The ones at the top did not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant