Dastardly Double Ducat Dipping Dagon

[Luftkommando]

Description of issue

The Dagon account, on account creation, takes from the main Dagon account but duplicates the money put into the new account up to a million Thaler from the original account since that's the max you can transfer to a new account.

Difference between expected and actual behavior

Expected: Money transfers from one side, to the other.

Difference: Money doubles in quantity and becomes Katamari situation.

Steps to reproduce

1: Create a new Dagon account.
(A weird quirk is that you need to do this on the second account, the first account made on the Dagon will always be account #0, and will never be able to be accessed.)

2: Name it whatever you want but put in 75000 Thaler as the new account's balance.

3: Go to ATM, check balance of the new account by just putting in the account # of the new account.

4: Thalers in account are 150000, not 75000 like they should be and the finance machine indicates that there were two deposits from the primary account.

Specific information for locating

I would assume that the issue is located in code/modules/economy/Accounts_DB.dm or at least somewhere within the folder that .dm comes from.

Length of time in which bug has been known to occur

At least as long as Hestia has been a thing away from Bay. I reported it on Old Hestia's codebase I think but it may have been a case of I made the report but never posted it.

Client version, Server revision & Game ID

Client Version: 513
Server Revision: c66ae6d - - 2021-01-02
Game ID: b0U-dGG9

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this