Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using doc_values for tags field #66

Open
lukas-vlcek opened this issue Nov 24, 2017 · 0 comments
Open

Consider using doc_values for tags field #66

lukas-vlcek opened this issue Nov 24, 2017 · 0 comments
Labels

Comments

@lukas-vlcek
Copy link
Member

Currently, the _default_ mapping specification disables doc_values for tags field. I think we should consider enabling it but it will require a bit of discussion and can introduce breaking change.

    # existing ES 2.x notation
    - name: tags
      type: string
      doc_values: false
      index: analyzed
      analyzer: whitespace
      description: >
        Optionally provided operator defined list of tags placed on each log
        by the collector or normalizer. The payload can be a string with
        whitespace-delimited string tokens, or a JSON list of string tokens.

Relevant read: https://www.elastic.co/guide/en/elasticsearch/reference/5.5/doc-values.html

Pros:

  • more efficient aggregations and sorting (I guess tags field is a good candidate to aggregate on)

Cons:

  • not possible on analyzed string which means users will be able to provide multiple tags only via an array, like: "tags": ["foo", "bar"] and no whitespace analyzer will be run on the content of individual values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant