Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

img src with data URI should not be cached #9

Open
rse43 opened this issue Nov 16, 2024 · 0 comments
Open

img src with data URI should not be cached #9

rse43 opened this issue Nov 16, 2024 · 0 comments

Comments

@rse43
Copy link

rse43 commented Nov 16, 2024

I've seen quite some errors in my pic-cache worker where the following URL could be cached. It turned out some images are embeded in HTML in Data URI and does not need to be cached.

GET https://xxx/piccache?url=data%3Aimage%2Fsvg%2Bxml%2C%253Csvg%2520xmlns%3D%2527http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%2527%2520version%3D%25271.1%2527%2520width%3D%25271886%2527%2520height%3D%25271936%2527%2F%253E"

It should be safe to skip all URLs starting with data: IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant