Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation clarification of forward_kld #64

Closed
adam2392 opened this issue Jul 9, 2024 · 1 comment
Closed

Documentation clarification of forward_kld #64

adam2392 opened this issue Jul 9, 2024 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@adam2392
Copy link
Contributor

adam2392 commented Jul 9, 2024

https://vincentstimper.github.io/normalizing-flows/references/#normflows.flows does not have an entry for y in the forward-kid function even though it is an input argument for forward_kld.

I was wondering what the description of y should be in this method? In log_prob(x, y), it specifies that y is the class. Is this the case? So given say a dataset of (X, y), we feed in batches of X and class labels y and want to minimize the KL divergence between the decoded \hat{X} and input X over each class label distribution?

@VincentStimper
Copy link
Owner

Hi @adam2392,

The documentation is indeed not clear there, thanks for pointing this out. In this case, y is the class in case the model is class-conditional. I clarified this in this commit.

Best regards,
Vincent

@VincentStimper VincentStimper self-assigned this Aug 25, 2024
@VincentStimper VincentStimper added the documentation Improvements or additions to documentation label Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants