Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Feature] Releasing Tiberium on death #580

Open
askhati opened this issue Sep 26, 2021 · 4 comments · May be fixed by #626
Open

[New Feature] Releasing Tiberium on death #580

askhati opened this issue Sep 26, 2021 · 4 comments · May be fixed by #626
Labels
new-feature New feature or request.

Comments

@askhati
Copy link

askhati commented Sep 26, 2021

Description:

Currently, when an unit has the tag "TiberiumHeal=yes", two things happen:

  • the unit will heal when standing in tiberium fields
  • ...and will ALSO release tiberium on death

For balancing and unit design purposes, it would be great if these two functions could be unbundled into separate tags.

Possible Implementation:

Create the following two new tags:

  • TiberiumHealer= y/n (heal in tib; nothing else)
  • TiberiumOnDeath= y/n (release tib on death)

That way, the vanilla "TiberiumHeal=" can be used on units that have both functions; for units that need only one of the two abilities, use the appropriate new tag.
@askhati askhati added the new-feature New feature or request. label Sep 26, 2021
@Rampastring
Copy link
Member

I think the almost-duplicate keys could end up being confusing. As an alternative, we could only add the TiberiumOnDeath key. The functionality that a unit would have with only TiberiumHealer=yes could be achieved with TiberiumHeal=yes and TiberiumOnDeath=no.

@ErastusMercy
Copy link

I agree with Rampa, I think the TiberiumOnDeath could simply act as an override for that element of the TiberiumHeal behaviour.

@CCHyper CCHyper self-assigned this Sep 27, 2021
@CCHyper
Copy link
Contributor

CCHyper commented Sep 27, 2021

Just checked this out, looks pretty straightforward.

Is there anything else related to this before I go ahead and work on this?

@askhati
Copy link
Author

askhati commented Sep 27, 2021 •
edited
Loading

As discussed on Discord, an update of the initial request would look like this:

  • only 1x new tag: "TiberiumOnDeath="
  • accepts true/false OR a valid Tiberium type from the Global list (Riparius, Arboreus, Vinifera, etc)
  • if no/false: use this to disable the tiberium-spawning effect of the existing WW tag "TiberiumHeal="
  • if yes/true: use this to spawn the first Tiberium type from the Global list
  • if a valid Tiberium type: spawn this Tiberium type on death; needs to interact with the existing WW "TiberiumHeal=" tag to potentially override the Tiberium type released by that (first) tag if it is different

@CCHyper CCHyper linked a pull request Oct 5, 2021 that will close this issue
Open
@CCHyper CCHyper moved this to In Progress in Vinifera - Initial Release Apr 8, 2022
@CCHyper CCHyper removed their assignment Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new-feature New feature or request.
Projects
Vinifera - Initial Release
Status: In Progress
Milestone
No milestone
4 participants
@Rampastring @ErastusMercy @CCHyper @askhati