Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Multiple pulls are queued if ssh key password is provided later #851

Open
parakhm95 opened this issue Jan 30, 2025 · 0 comments
Open
Labels
bug Something isn't working

Comments

@parakhm95
Copy link

Describe the bug

Sometimes when I log-in and the OS autolaunches obsidian, the dialog for entering password to my key gets ignored if I am working on something else. But, at the end of the day when I notice it and provide the password, it performs all the pulls it had queued in the background waiting for the key and executes all of them, there-by, spamming obsidian with multiple notifications that say "Pull: Everything is upto date". When it has run out of them, it stops.

Relevant errors (if available) from notifications or console (CTRL+SHIFT+I)

Steps to reproduce

  • Make a SSH Key with password
  • Enable Obsidian git and configure it to pull every X mins.
  • launch system without auto keyring configured such that dialog needs to be filled-in for SSH key password
  • Ignore the dialogue box for an hour
  • Enter the password in the dialog box
  • Observe

Expected Behavior

No response

Addition context

{ "settings": { "commitMessage": "vault backup: {{date}}", "commitDateFormat": "YYYY-MM-DD HH:mm:ss", "autoSaveInterval": 5, "autoPushInterval": 0, "autoPullInterval": 5, "autoPullOnBoot": false, "disablePush": false, "pullBeforePush": true, "disablePopups": false, "disablePopupsForNoChanges": false, "listChangedFilesInMessageBody": false, "showStatusBar": true, "updateSubmodules": false, "syncMethod": "merge", "customMessageOnAutoBackup": false, "autoBackupAfterFileChange": true, "treeStructure": false, "refreshSourceControl": true, "basePath": "", "differentIntervalCommitAndPush": false, "changedFilesInStatusBar": false, "showedMobileNotice": true, "refreshSourceControlTimer": 7000, "showBranchStatusBar": true, "setLastSaveToLastCommit": false, "submoduleRecurseCheckout": false, "gitDir": "", "showFileMenu": true, "authorInHistoryView": "hide", "dateInHistoryView": false, "lineAuthor": { "show": false, "followMovement": "inactive", "authorDisplay": "initials", "showCommitHash": false, "dateTimeFormatOptions": "date", "dateTimeFormatCustomString": "YYYY-MM-DD HH:mm", "dateTimeTimezone": "viewer-local", "coloringMaxAge": "1y", "colorNew": { "r": 255, "g": 150, "b": 150 }, "colorOld": { "r": 120, "g": 160, "b": 255 }, "textColorCss": "var(--text-muted)", "ignoreWhitespace": false, "gutterSpacingFallbackLength": 5, "lastShownAuthorDisplay": "initials", "lastShownDateTimeFormatOptions": "date" }, "autoCommitMessage": "vault backup: {{date}}" }, "pluginVersion": "2.30.1" }

Operating system

Linux

Installation Method

Snap

Plugin version

2.30.1

@parakhm95 parakhm95 added the bug Something isn't working label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant