From 1dcf299a1014cc9ed58b97b63bda86cbf2442a62 Mon Sep 17 00:00:00 2001
From: Oleg Zhuk <zhukoo@gmail.com>
Date: Tue, 4 Jun 2024 15:55:16 +0200
Subject: [PATCH] VCST-1251: Add unregister notification (#160)

fix: Impoved Unregistered Notifcation UX with displaying correct original type.
---
 .../Model/UnregisteredNotification.cs                    | 7 ++++++-
 .../Services/NotificationRegistrar.cs                    | 1 -
 .../Services/NotificationService.cs                      | 2 +-
 .../Localizations/en.VirtoCommerce.Notifications.json    | 2 +-
 .../Localizations/ru.VirtoCommerce.Notifications.json    | 2 +-
 .../Scripts/blades/notification-templates-list.js        | 7 ++++---
 .../Scripts/blades/notifications-list.js                 | 9 +++++----
 7 files changed, 18 insertions(+), 12 deletions(-)

diff --git a/src/VirtoCommerce.NotificationsModule.Core/Model/UnregisteredNotification.cs b/src/VirtoCommerce.NotificationsModule.Core/Model/UnregisteredNotification.cs
index 14c83a48..ecc13e71 100644
--- a/src/VirtoCommerce.NotificationsModule.Core/Model/UnregisteredNotification.cs
+++ b/src/VirtoCommerce.NotificationsModule.Core/Model/UnregisteredNotification.cs
@@ -6,12 +6,17 @@ namespace VirtoCommerce.NotificationsModule.Core.Model
     //The special type for handle cases when  the system have stored the notification objects with unregistered types. 
     public class UnregisteredNotification : Notification
     {
+        public UnregisteredNotification(string type) : base(type)
+        {
+
+        }
+
         public UnregisteredNotification() : base(nameof(UnregisteredNotification))
         {
             Templates = new List<NotificationTemplate>();
         }
         public override string Kind => "undef";
-        
+
 
         public override void SetFromToMembers(string from, string to)
         {
diff --git a/src/VirtoCommerce.NotificationsModule.Data/Services/NotificationRegistrar.cs b/src/VirtoCommerce.NotificationsModule.Data/Services/NotificationRegistrar.cs
index b7c547bd..5de9eab5 100644
--- a/src/VirtoCommerce.NotificationsModule.Data/Services/NotificationRegistrar.cs
+++ b/src/VirtoCommerce.NotificationsModule.Data/Services/NotificationRegistrar.cs
@@ -47,6 +47,5 @@ public NotificationBuilder OverrideNotificationType<TOldNotificationType, TNewNo
 
             return builder;
         }
-
     }
 }
diff --git a/src/VirtoCommerce.NotificationsModule.Data/Services/NotificationService.cs b/src/VirtoCommerce.NotificationsModule.Data/Services/NotificationService.cs
index 810ee948..33eca82d 100644
--- a/src/VirtoCommerce.NotificationsModule.Data/Services/NotificationService.cs
+++ b/src/VirtoCommerce.NotificationsModule.Data/Services/NotificationService.cs
@@ -174,7 +174,7 @@ private static Notification ToModel(NotificationEntity entity)
                 entity.ToModel(result);
             }
 
-            return result ?? new UnregisteredNotification();
+            return result ?? new UnregisteredNotification(typeName);
         }
     }
 }
diff --git a/src/VirtoCommerce.NotificationsModule.Web/Localizations/en.VirtoCommerce.Notifications.json b/src/VirtoCommerce.NotificationsModule.Web/Localizations/en.VirtoCommerce.Notifications.json
index 109197e2..5dbc5c94 100644
--- a/src/VirtoCommerce.NotificationsModule.Web/Localizations/en.VirtoCommerce.Notifications.json
+++ b/src/VirtoCommerce.NotificationsModule.Web/Localizations/en.VirtoCommerce.Notifications.json
@@ -210,7 +210,7 @@
     "dialogs": {
       "unknown-kind": {
         "title": "Error",
-        "message": "Unable to edit template of an unknown type: '{{kind}}'."
+        "message": "Unable to open '{{type}}' notification. Please contact your Site Administrator(s) for information."
       },
       "notification-details-save": {
         "title": "Save changes",
diff --git a/src/VirtoCommerce.NotificationsModule.Web/Localizations/ru.VirtoCommerce.Notifications.json b/src/VirtoCommerce.NotificationsModule.Web/Localizations/ru.VirtoCommerce.Notifications.json
index e9f8dbc0..88ff62f9 100644
--- a/src/VirtoCommerce.NotificationsModule.Web/Localizations/ru.VirtoCommerce.Notifications.json
+++ b/src/VirtoCommerce.NotificationsModule.Web/Localizations/ru.VirtoCommerce.Notifications.json
@@ -207,7 +207,7 @@
     "dialogs": {
       "unknown-kind": {
         "title": "Ошибка",
-        "message": "Невозможно изменить шаблон неопределенного типа:: '{{kind}}'."
+        "message": "Невозможно открыть уведомление '{{type}}'. Обратитесь к администратору(ам) вашего сайта за информацией."
       },
       "notification-details-save": {
         "title": "Сохранить изменения",
diff --git a/src/VirtoCommerce.NotificationsModule.Web/Scripts/blades/notification-templates-list.js b/src/VirtoCommerce.NotificationsModule.Web/Scripts/blades/notification-templates-list.js
index 4c764732..a7562e42 100644
--- a/src/VirtoCommerce.NotificationsModule.Web/Scripts/blades/notification-templates-list.js
+++ b/src/VirtoCommerce.NotificationsModule.Web/Scripts/blades/notification-templates-list.js
@@ -40,7 +40,7 @@ angular.module('virtoCommerce.notificationsModule')
                 return _.toArray(templatesToDisplay);
             }
 
-            function resolveType(kind) {
+            function resolveType(kind, type) {
                 var foundTemplate = notificationTemplatesResolverService.resolve(kind);
                 if (foundTemplate && foundTemplate.knownChildrenTypes && foundTemplate.knownChildrenTypes.length) {
                     return foundTemplate;
@@ -49,13 +49,14 @@ angular.module('virtoCommerce.notificationsModule')
                         id: "error",
                         title: "notifications.dialogs.unknown-kind.title",
                         message: "notifications.dialogs.unknown-kind.message",
-                        messageValues: { kind: kind },
+                        messageValues: { kind: kind, type: type },
                     });
+                    return null;
                 }
             }
 
             blade.openTemplate = function (template) {
-                var foundTemplate = resolveType(blade.currentEntity.kind);
+                var foundTemplate = resolveType(blade.currentEntity.kind, blade.currentEntity.type);
                 if (foundTemplate) {
                     var newBlade = {
                         id: foundTemplate.detailBlade.id,
diff --git a/src/VirtoCommerce.NotificationsModule.Web/Scripts/blades/notifications-list.js b/src/VirtoCommerce.NotificationsModule.Web/Scripts/blades/notifications-list.js
index 949f66ae..1bb0f2fe 100644
--- a/src/VirtoCommerce.NotificationsModule.Web/Scripts/blades/notifications-list.js
+++ b/src/VirtoCommerce.NotificationsModule.Web/Scripts/blades/notifications-list.js
@@ -49,7 +49,7 @@ angular.module('virtoCommerce.notificationsModule')
             });
         }
 
-        function resolveType(kind) {
+        function resolveType(kind, type) {
             var foundNotification = notificationTypesResolverService.resolve(kind);
             if (foundNotification && foundNotification.knownChildrenTypes && foundNotification.knownChildrenTypes.length) {
                     return foundNotification;
@@ -58,14 +58,15 @@ angular.module('virtoCommerce.notificationsModule')
                         id: "error",
                         title: "notifications.dialogs.unknown-kind.title",
                         message: "notifications.dialogs.unknown-kind.message",
-                        messageValues: { kind: kind },
-                });
+                        messageValues: { kind: kind, type: type },
+                    });
+                return null;
             }
         }
 
         if (authService.checkPermission('notifications:access')) {
             blade.editNotification = function (item) {
-                var foundNotification = resolveType(item.kind);
+                var foundNotification = resolveType(item.kind, item.type);
                 var newBlade = {
                     id: 'editNotification',
                     title: 'notifications.blades.notification-details.title',