Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context to yara.Error exception #104

Open
jipegit opened this issue Mar 5, 2019 · 4 comments
Open

Add context to yara.Error exception #104

jipegit opened this issue Mar 5, 2019 · 4 comments

Comments

@jipegit
Copy link

jipegit commented Mar 5, 2019

It would be very useful to add context to yara.Error Exception, especially the rule name causing internal errors (TOO_MANY_MATCHES or else).

@wxsBSD
Copy link
Contributor

wxsBSD commented Mar 6, 2019

I have a patch almost ready to do this but I got pulled into some stuff for $job so give me a little more time. :)

I'm switching yara-python over to using the (relatively new) scanner API. It's mostly done, just have to fix up support for external variables.

@wxsBSD
Copy link
Contributor

wxsBSD commented Mar 8, 2019

@jipegit Would you be willing to try out the scanner_api branch on my fork? I'm not super happy with the changes in it, but it seems to work well for me (and passes tests). I'll have to come up with a better way to handle errors so it isn't so cumbersome, but I'd appreciate any testing you can do on it.

@jipegit
Copy link
Author

jipegit commented Mar 11, 2019

Did some testing and it looks ok to me.

Thank you!

@jipegit jipegit closed this as completed Mar 11, 2019
@wxsBSD
Copy link
Contributor

wxsBSD commented Mar 11, 2019

I haven’t actually submitted this yet. Would you please reopen and I’ll see if I can clean it up and get it submitted?

@jipegit jipegit reopened this Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants