Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Questions about 'use_question_query' in V-RAG #1

Open
JarvisUSTC opened this issue Jan 2, 2025 · 4 comments
Open

Questions about 'use_question_query' in V-RAG #1

JarvisUSTC opened this issue Jan 2, 2025 · 4 comments

Comments

@JarvisUSTC
Copy link

I’m not sure why the use_question_query option wasn’t set to true in the scripts. Without it, the queries will remain empty since the "needle" in the datasets is not populated.
@junchen14
Copy link
Collaborator

we have updated the scripts and make the use_question_query=True by default

@JarvisUSTC
Copy link
Author

Additionally, the argument top_k_filter is not valid in the code.

@junchen14
Copy link
Collaborator

top_k_filter is 60 by default

@JarvisUSTC
Copy link
Author

But the top_k_filter is not used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@junchen14 @JarvisUSTC