Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"options" should be optional when running "vrtTrack" #27

Open
ngraf opened this issue Apr 27, 2021 · 2 comments
Open

"options" should be optional when running "vrtTrack" #27

ngraf opened this issue Apr 27, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ngraf
Copy link

ngraf commented Apr 27, 2021

agent-codeceptjs/lib/index.ts

Line 41 in 3891780

async vrtTrack(name: string, options: TrackOptions) {

Why "options" is mandatory?
Please make it optional, so that Typescript linting is not complaining.
Why I have this expectation? Because in the README.md an example is given where no option is passed to vrtTrack and because I personally also think it makes sense to make it optional when there is no reason to make it mandatory.
@pashidlos
Copy link
Member

@ngraf good point!
would you like to contribute with the fix?

@pashidlos pashidlos added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Apr 29, 2021
@ngraf
Copy link
Author

ngraf commented May 3, 2021

No, sorry. I am not a good developer. I am just a passionate QA/user of the agent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pashidlos @ngraf