Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unused parameters in GetDiffClo*Days in ITS.R #23

Open
jgbarah opened this issue Nov 25, 2013 · 1 comment
Open

Removing unused parameters in GetDiffClo*Days in ITS.R #23

jgbarah opened this issue Nov 25, 2013 · 1 comment
Assignees
@jgbarah
Labels
enhancement

Comments

@jgbarah
Copy link
Member

jgbarah commented Nov 25, 2013

GetDiffClosedDays and GetDiffClosersDays accept a period parameter which is not used at all. It should be removed.

WARNING: This implies a change in API.
@ghost ghost assigned jgbarah Nov 25, 2013
jgbarah added a commit that referenced this issue Nov 25, 2013
@jgbarah
Fixed issue #23.
3fb125a 
WARNING: Change in API for functions GetDiffClosedDays and GetDiffClosersDays
in ITS.R:
  - First parameter (period) removed, since it is no longer used.
  - Second (now first) parameter (init_date) is now "date".
@jgbarah
Copy link
Member Author

jgbarah commented Nov 25, 2013

Closed in branch issue-23

@jgbarah jgbarah mentioned this issue Nov 25, 2013
Merged
dicortazar added a commit that referenced this issue Nov 26, 2013
@dicortazar
Merge pull request #24 from VizGrimoire/issue-23
75e7ce5 
Fixed issue #23.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgbarah jgbarah

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jgbarah