Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRC.R Refactoring #44

Open
dicortazar opened this issue Jan 10, 2014 · 0 comments
Open

IRC.R Refactoring #44

dicortazar opened this issue Jan 10, 2014 · 0 comments

Comments

@dicortazar
Copy link
Member

Typically, functions should follow the same workflow. However in IRC, depending on the function,

  • this is using its own workflow (so building its own query). (StaticNumSentIRC)
  • in other cases it aimed at using the common workflow (but for some reason this is using SCM query constructors) (GetSentIRC)
  • and in other cases those are using some internal workflow (GetListPeopleIRC)

Those using SCM functions will probably fail if another type of analysis different from the basic analysis is performed.

In addition extra testing should be added in any case...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant