Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid unit tests: assert_almost_equal #198

Open
jonlym opened this issue Jul 11, 2022 · 0 comments
Open

Invalid unit tests: assert_almost_equal #198

jonlym opened this issue Jul 11, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@jonlym
Copy link
Member

jonlym commented Jul 11, 2022

Many floating point unit tests use numpy's assert_almost_equal. However, this sometimes incorrectly passes for very small numbers. Instead, we should use assert_allclose instead.
@jonlym jonlym added the bug Something isn't working label Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonlym