Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Only shows most recent episode for certain podcasts #421

Open
alcinnz opened this issue Sep 26, 2019 · 3 comments
Open

Only shows most recent episode for certain podcasts #421

alcinnz opened this issue Sep 26, 2019 · 3 comments

Comments

@alcinnz
Copy link
Contributor

alcinnz commented Sep 26, 2019

If you subscribe to https://expeditionsasquatch.org/episodes.ogg.rss in Vocal, it shows only the most recent episode. As of reporting this issue, I expect to see all three episodes listed.

@nathandyer
Copy link
Member

Thanks for the report! We'll take a look.

@psetq
Copy link
Contributor

psetq commented Nov 27, 2019

This is an interesting issue since it actually highlights 2 bugs.

Given the following episode feed structure:

<item>
  <title>Episode 4 - Hunting the Sasquatch King</title>
  ...
  <image>
    <title>The only known photograph of a Ro-Man, Robot Monster</title>
    ...
  </image>
</item>

The second/inner title element will override the first one for the item element due to the way the feed data is flattened into a queue (ArrayList) by the feed parser. A better solution might be to parse the feed directly as the atom parsing methods do and skip the intermediate queue step.

Next, since each item will use the same image > title which overwrites the distinct title, will trigger the duplicate title problem described in #320

Lastly, there is some inconsistency in the feed parser/updating where, when feeds are initially fetched the ui is created from the fetched data (with duplicate titles) and the data then sent to the db resulting in each episode overwriting the previous. On the next library reload, only the single episode will be shown. A better strategy might be to consistently have user/network data populate the library/database, and have the ui always build from the library/database data.

@nathandyer
Copy link
Member

@psetq You are exactly correct about everything here. I don't believe we'll be able to get this in for the 3.0 release, but I do want to make these changes (or see them made if somebody beats me to it) and hopefully get them into 3.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants