Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Visual studio 2022 CMake preset #4656

Merged
merged 6 commits into from
Jul 18, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions CMakePresets.json
Original file line number Diff line number Diff line change
@@ -218,6 +218,53 @@
"value": "On"
}
}
},
{
"name": "vs2022-vcpkg-no-sys-deps",
"generator": "Visual Studio 17 2022",
"binaryDir": "${sourceDir}/build",
"cacheVariables": {
"CMAKE_TOOLCHAIN_FILE": {
"type": "FILEPATH",
"value": "${sourceDir}/ext_libs/vcpkg/scripts/buildsystems/vcpkg.cmake"
},
"BUILD_TESTING": {
"type": "BOOL",
"value": "ON"
},
"RAPIDJSON_SYS_DEP": {
"type": "BOOL",
"value": "OFF"
},
"FMT_SYS_DEP": {
"type": "BOOL",
"value": "OFF"
},
"SPDLOG_SYS_DEP": {
"type": "BOOL",
"value": "OFF"
},
"VW_BOOST_MATH_SYS_DEP": {
"type": "BOOL",
"value": "OFF"
},
"VW_ZLIB_SYS_DEP": {
"type": "BOOL",
"value": "OFF"
},
"VW_GTEST_SYS_DEP": {
"type": "BOOL",
"value": "OFF"
},
"VW_EIGEN_SYS_DEP": {
"type": "BOOL",
"value": "OFF"
},
"VW_STRING_VIEW_LITE_SYS_DEP": {
"type": "BOOL",
"value": "OFF"
}
}
}
],
"buildPresets": [

Unchanged files with check annotations Beta

, spanner_state(c, d)
, shrink_fact_config(apply_shrink_factor)
, impl(all, d, _seed, total_size, thread_pool_size, block_size, action_cache_slack, use_explicit_simd)
{

Check warning on line 246 in vowpalwabbit/core/src/reductions/cb/cb_explore_adf_large_action_space.cc

GitHub Actions / windows-latest-vcpkg-debug-Vcpkg build

'void VW::cb_explore_adf::cb_explore_adf_large_action_space<VW::cb_explore_adf::one_pass_svd_impl,VW::cb_explore_adf::one_rank_spanner_state>::save_load(VW::io_buf &,bool,bool)': no suitable definition provided for explicit template instantiation request

Check warning on line 246 in vowpalwabbit/core/src/reductions/cb/cb_explore_adf_large_action_space.cc

GitHub Actions / windows-latest-vcpkg-debug-Vcpkg build

'void VW::cb_explore_adf::cb_explore_adf_large_action_space<VW::cb_explore_adf::two_pass_svd_impl,VW::cb_explore_adf::one_rank_spanner_state>::save_load(VW::io_buf &,bool,bool)': no suitable definition provided for explicit template instantiation request

Check warning on line 246 in vowpalwabbit/core/src/reductions/cb/cb_explore_adf_large_action_space.cc

GitHub Actions / windows-latest-vcpkg-release-Vcpkg build

'void VW::cb_explore_adf::cb_explore_adf_large_action_space<VW::cb_explore_adf::one_pass_svd_impl,VW::cb_explore_adf::one_rank_spanner_state>::save_load(VW::io_buf &,bool,bool)': no suitable definition provided for explicit template instantiation request

Check warning on line 246 in vowpalwabbit/core/src/reductions/cb/cb_explore_adf_large_action_space.cc

GitHub Actions / windows-latest-vcpkg-release-Vcpkg build

'void VW::cb_explore_adf::cb_explore_adf_large_action_space<VW::cb_explore_adf::two_pass_svd_impl,VW::cb_explore_adf::one_rank_spanner_state>::save_load(VW::io_buf &,bool,bool)': no suitable definition provided for explicit template instantiation request
}
shrink_factor_config::shrink_factor_config(bool apply_shrink_factor) : _apply_shrink_factor(apply_shrink_factor) {}
else { shrink_factors.resize(preds.size(), 1.f); }
}
template class cb_explore_adf_large_action_space<one_pass_svd_impl, one_rank_spanner_state>;

Check warning on line 266 in vowpalwabbit/core/src/reductions/cb/cb_explore_adf_large_action_space.cc

GitHub Actions / windows-latest-vcpkg-debug-Vcpkg build

'void VW::cb_explore_adf::cb_explore_adf_large_action_space<VW::cb_explore_adf::one_pass_svd_impl,VW::cb_explore_adf::one_rank_spanner_state>::save_load(VW::io_buf &,bool,bool)': no suitable definition provided for explicit template instantiation request

Check warning on line 266 in vowpalwabbit/core/src/reductions/cb/cb_explore_adf_large_action_space.cc

GitHub Actions / windows-latest-vcpkg-release-Vcpkg build

'void VW::cb_explore_adf::cb_explore_adf_large_action_space<VW::cb_explore_adf::one_pass_svd_impl,VW::cb_explore_adf::one_rank_spanner_state>::save_load(VW::io_buf &,bool,bool)': no suitable definition provided for explicit template instantiation request
template class cb_explore_adf_large_action_space<two_pass_svd_impl, one_rank_spanner_state>;

Check warning on line 267 in vowpalwabbit/core/src/reductions/cb/cb_explore_adf_large_action_space.cc

GitHub Actions / windows-latest-vcpkg-debug-Vcpkg build

'void VW::cb_explore_adf::cb_explore_adf_large_action_space<VW::cb_explore_adf::two_pass_svd_impl,VW::cb_explore_adf::one_rank_spanner_state>::save_load(VW::io_buf &,bool,bool)': no suitable definition provided for explicit template instantiation request

Check warning on line 267 in vowpalwabbit/core/src/reductions/cb/cb_explore_adf_large_action_space.cc

GitHub Actions / windows-latest-vcpkg-release-Vcpkg build

'void VW::cb_explore_adf::cb_explore_adf_large_action_space<VW::cb_explore_adf::two_pass_svd_impl,VW::cb_explore_adf::one_rank_spanner_state>::save_load(VW::io_buf &,bool,bool)': no suitable definition provided for explicit template instantiation request
} // namespace cb_explore_adf
} // namespace VW
VW::workspace* all = nullptr;
try
{
all = VW::initialize(std::move(options));

Check warning on line 32 in utl/flatbuffer/txt_to_flat.cc

GitHub Actions / asan.ubuntu-latest.vcpkg-asan-debug

‘VW::workspace* VW::initialize(std::unique_ptr<VW::config::options_i, void (*)(VW::config::options_i*)>, VW::io_buf*, bool, VW::trace_message_t, void*)’ is deprecated: Replaced with new unique_ptr based overload. [-Wdeprecated-declarations]

Check warning on line 32 in utl/flatbuffer/txt_to_flat.cc

GitHub Actions / asan.macos-13.vcpkg-asan-debug

'initialize' is deprecated: Replaced with new unique_ptr based overload. [-Wdeprecated-declarations]

Check warning on line 32 in utl/flatbuffer/txt_to_flat.cc

GitHub Actions / asan.macos-13.vcpkg-ubsan-debug

'initialize' is deprecated: Replaced with new unique_ptr based overload. [-Wdeprecated-declarations]
}
catch (const std::exception& ex)
{
#else
std::string utf16_to_utf8(const std::u16string& utf16_string)
{
std::wstring_convert<std::codecvt_utf8_utf16<char16_t>, char16_t> convert;

Check warning on line 47 in vowpalwabbit/c_wrapper/src/vwdll.cc

GitHub Actions / asan.macos-13.vcpkg-asan-debug

'codecvt_utf8_utf16<char16_t>' is deprecated [-Wdeprecated-declarations]

Check warning on line 47 in vowpalwabbit/c_wrapper/src/vwdll.cc

GitHub Actions / asan.macos-13.vcpkg-asan-debug

'wstring_convert<std::codecvt_utf8_utf16<char16_t>, char16_t>' is deprecated [-Wdeprecated-declarations]

Check warning on line 47 in vowpalwabbit/c_wrapper/src/vwdll.cc

GitHub Actions / asan.macos-13.vcpkg-ubsan-debug

'codecvt_utf8_utf16<char16_t>' is deprecated [-Wdeprecated-declarations]

Check warning on line 47 in vowpalwabbit/c_wrapper/src/vwdll.cc

GitHub Actions / asan.macos-13.vcpkg-ubsan-debug

'wstring_convert<std::codecvt_utf8_utf16<char16_t>, char16_t>' is deprecated [-Wdeprecated-declarations]
return convert.to_bytes(utf16_string);
}
#endif
// Create namespace when audit is false
flatbuffers::Offset<VW::parsers::flatbuffer::Namespace> to_flat::create_namespace(
features::const_iterator begin, features::const_iterator end, VW::namespace_index index, uint64_t hash)

Check warning on line 345 in utl/flatbuffer/vw_to_flat.cc

GitHub Actions / asan.macos-13.vcpkg-asan-debug

'features' is deprecated: Moved into VW namespace. Will be removed in VW 10. [-Wdeprecated-declarations]

Check warning on line 345 in utl/flatbuffer/vw_to_flat.cc

GitHub Actions / asan.macos-13.vcpkg-asan-debug

'features' is deprecated: Moved into VW namespace. Will be removed in VW 10. [-Wdeprecated-declarations]

Check warning on line 345 in utl/flatbuffer/vw_to_flat.cc

GitHub Actions / asan.macos-13.vcpkg-ubsan-debug

'features' is deprecated: Moved into VW namespace. Will be removed in VW 10. [-Wdeprecated-declarations]

Check warning on line 345 in utl/flatbuffer/vw_to_flat.cc

GitHub Actions / asan.macos-13.vcpkg-ubsan-debug

'features' is deprecated: Moved into VW namespace. Will be removed in VW 10. [-Wdeprecated-declarations]
{
std::stringstream ss;
ss << index;