Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

launcher process doesn't exit #838

Open
1 task done
paring-chan opened this issue Nov 3, 2024 · 7 comments
Open
1 task done

launcher process doesn't exit #838

paring-chan opened this issue Nov 3, 2024 · 7 comments
Labels

Comments

@paring-chan
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Launcher Version

v0.47.10

Operating System

Linux

Architecture

x64

Current Behavior

while running some tasks on the launcher(installing, launching, etc), it occasionally freezes and doesn't respond if I hit cancel button. Then the process won't be killed even with SIGKILL

Expected Behavior

No response

Steps To Reproduce

  1. Do any task like launching, installing, updating instance and check if it freezes
  2. Then stop xmcl
  3. Check task manager: it still remains and killing the process does not work

Anything else?

I'm using KDE Plasma 6.2.2 on Wayland and system is running with NixOS

@paring-chan paring-chan added the bug label Nov 3, 2024
@ci010
Copy link
Collaborator

ci010 commented Nov 4, 2024

I observe this sometime in my dev env. I guess this might be related to database operation not disposed after quit? I need to take more time to investigate it.

@paring-chan
Copy link
Contributor Author

paring-chan commented Nov 4, 2024

I guess it's an issue from electron. The main process actually exits(but I think it can be just an wrapper), but (maybe) child processes become zombie(actually the window doesn't disappear), but I think the task freezing is another issue

I'll let you know if the freeze on exit disappears with latest electron(I can use the launcher with latest electron in nixpkgs)

@paring-chan
Copy link
Contributor Author

I tried using xmcl with latest electron:

at least the launcher doesn't freeze when terminating, but the task freezing exists though

@BANSAFAn
Copy link
Contributor

I tried using xmcl with latest electron:

at least the launcher doesn't freeze when terminating, but the task freezing exists though

I can find out exactly what Linux distribution you have ?

@ci010
Copy link
Collaborator

ci010 commented Nov 22, 2024

@paring-chan could u try the latest commit build? I added some missing dispositions for some resources. These resources might block process exit.

@paring-chan
Copy link
Contributor Author

paring-chan commented Nov 22, 2024

I can find out exactly what Linux distribution you have ?

I'm on NixOS Unstable with KDE Plasma Wayland 6.2

@paring-chan
Copy link
Contributor Author

paring-chan commented Nov 23, 2024

@paring-chan could u try the latest commit build? I added some missing dispositions for some resources. These resources might block process exit.

it didn't fix

image

Additional information

I think this can be caused by AppImage(or NixOS's appimage related something) because manually opening the app with electron cli doesn't make that issue

The main command actually exits(./xmcl-xxx.AppImage), but the windows don't close and becomes can't be killed
reference:
image

The process becomes completely unresponsive and even can't killed while shutting down the system(hangs infinitely
unless I force power off/reset the system)
reference:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants