Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

reverseYears prop should only reverse the order in years overlay and months overlay should be unaffected #123

Closed
voidst1 opened this issue Mar 15, 2022 · 2 comments
Closed

reverseYears prop should only reverse the order in years overlay and months overlay should be unaffected #123

voidst1 opened this issue Mar 15, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@voidst1
Copy link

voidst1 commented Mar 15, 2022 •
edited
Loading

Describe the bug
When reverseYears prop is set to true, the rows in months overlay is also reversed.

Mar Feb Jan
Jun May Apr
Sep Aug Jul
Dec Nov Oct

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://vue3datepicker.com/api/props/#reverseyears
  2. Click on the date picker, then click on the month.
  3. See months overlay.

Expected behavior
The month overlay should remain in it's original order and the reverseYears prop should have no effect on it.

Screenshots
Not able to attach.

I have fixed this and will commit the codes after submitting this bug report.
@voidst1 voidst1 changed the title reverseYears prop should only reverse the order in years overlay and months overlay should be unaffected. reverseYears prop should only reverse the order in years overlay and months overlay should be unaffected Mar 15, 2022
voidst1 pushed a commit to voidst1/vue3-date-time-picker that referenced this issue Mar 15, 2022
fix: Fixed bug Vuepic#123\nreverseYears prop should only reverse the …
170bbde 
…order in years overlay and months overlay should be unaffected
voidst1 pushed a commit to voidst1/vue3-date-time-picker that referenced this issue Mar 15, 2022
fix: Fixed bug Vuepic#123
399546b
@Jasenkoo Jasenkoo added the bug Something isn't working label Mar 15, 2022
@Jasenkoo
Copy link
Contributor

Jasenkoo commented Mar 15, 2022 •
edited
Loading

Thx for fixing it, I don't know if you saw (#121), but will include the fix in the new version, should be live this weekend.

@voidst1
Copy link
Author

voidst1 commented Mar 15, 2022

Yes, I did saw. Great work and I look forward to it.

Jasenkoo added a commit that referenced this issue Mar 15, 2022
@Jasenkoo
Merge pull request #124 from voidst1/main
ba832e9 
fix: Fix reverseYears reversing months overlay (fixes #123)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jasenkoo @voidst1