Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Implement an additional sound that triggers upon successful punish #27

Open
int3r opened this issue Nov 12, 2020 · 0 comments

Comments

@int3r
Copy link

int3r commented Nov 12, 2020

Got a suggestion that should be super simple to implement: similar to Alchemy-Meister's fork, add another sound that triggers when you successfully land a punish.

I was able to get a janky version of it working in a few minutes with no python knowledge, so I'm sure there's more efficient methods, or something I might have missed, but this would definitely be very easy to implement :)

in SoundPlayer.py:

def play_correct()
    winsound.PlaySound("TekkenData/Sound/correct.wav", winsound.SND_ASYNC)

then edit the logic in GUI_PunishCoachOverlay.py to trigger the sound

def play_sound_by_punish(self):

    if self.current_window.result in (PunishWindow.Result.JAB_ON_NOT_LAUNCHABLE, PunishWindow.Result.LAUNCH_ON_LAUNCHABLE)
    SoundPlayer.SoundPlayer.play_correct()

Thanks for your continued support of this project! It significantly improves the quality of my practice mode grind!

EDIT: Could also break out the Punish Alarm functions so users can use the frame data display at the same time, and/or support multiple modes/overlays at once, but those are obviously a bit more work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant