Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX for Buttons #21

Open
jamesryan-dev opened this issue Jul 16, 2016 · 2 comments
Open

UX for Buttons #21

jamesryan-dev opened this issue Jul 16, 2016 · 2 comments
Assignees

Comments

@jamesryan-dev
Copy link
Contributor

Synchronise styling for all buttons so same

@SiAdcock
Copy link
Member

SiAdcock commented Dec 24, 2016

The styling for the Add to Calendar and Slack buttons is all over the place:

I'd recommend replacing the classes on these buttons (currently atc-style-blue and socialButton) with a new class, let's call it button--social. We can define this in the button component, using the styles defined in the add to calendar component. The Slack button and Add To Calendar buttons could all use this same class.

Since we are overriding most of the atc-style-blue.css styles, it is probably worth swapping this out for atc-base.css (Implemented in #80)

This could cause further unforeseen problems! Let's see how we get on 😅

@jamesryan-dev
Copy link
Contributor Author

ahhhh just seen this @SiAdcock yeh the ATC Button isn't gr8.. I wonder how many people actually even use it??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants