Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type piracy with Colors.RGB #36

Closed
j-fu opened this issue Nov 11, 2024 · 2 comments · Fixed by #43
Closed

Fix type piracy with Colors.RGB #36

j-fu opened this issue Nov 11, 2024 · 2 comments · Fixed by #43

Comments

@j-fu
Copy link
Member

j-fu commented Nov 11, 2024

Colors.RGB gets methods for string and symbols in GridVisualizeTools.
This is type piracy. May be can be replace by parse() (see Colors.jl docs).

@jpthiele
Copy link
Contributor

I think the only real occurence in this repo might be

rgb(v) = RGB(v, 0.0, 1.0 - v)

Otherwise rgbtuple is used which is defined in GridVisualizeTools.jl/src/colors.jl
so I think we should rewrite that function to use parse, right?

@jpthiele
Copy link
Contributor

jpthiele commented Nov 20, 2024

See: WIAS-PDELib/GridVisualizeTools.jl#12
and please check if everything still works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants