Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling various origin types #160

Open
marcoscaceres opened this issue Aug 20, 2024 · 3 comments
Open

Handling various origin types #160

marcoscaceres opened this issue Aug 20, 2024 · 3 comments
Assignees
Labels

Comments

@marcoscaceres
Copy link
Collaborator

When calling .get(), we need to check:

  • origin is opaque origin? Throw SecurityError.
  • is the effective domain a valid domain? no, then throw SecurityError.

As with Web Auth, we probably don't want IP addresses being compared here.

@OR13
Copy link
Contributor

OR13 commented Aug 20, 2024

What's an example of an invalid domain?

I assume you don't plan to do any TLSA or DNSSEC checks. The domain could be any DNS resolvable IDNA, according to UTS46.

Right?

@samuelgoto
Copy link
Collaborator

samuelgoto commented Aug 20, 2024

navigator.identity is already protected under SecureContext, wouldn't this already cover "origin is opaque origin?" and "is the effective domain a valid domain?"?

@timcappalli timcappalli self-assigned this Sep 9, 2024
@timcappalli
Copy link
Member

navigator.identity is already protected under SecureContext, wouldn't this already cover "origin is opaque origin?" and "is the effective domain a valid domain?"?

That is my understanding. @marcoscaceres does this match your understanding as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants