Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to a domain's first-party-set.json after github submission #151

Open
brownwolf1355 opened this issue Apr 26, 2023 · 4 comments
Open

Comments

@brownwolf1355
Copy link

The use of a centralized github repository for aggregation of First Party Sets creates a cache consistency issue. It is possible that a domain's first-party-set.json becomes modified, either as a result of a merger, reorganization, bad actor, the site is taken down, or simply human error, and does not get resubmitted to the github repository. The github repository is effectively the cache, while the first-party-set.json at each domain may reflect the current state of their FPS.

As I understand it, either at each new FPS submission or during the weekly merge, the contents of the github repository is checked against the first-party-set.json files for all domains that have submitted an FPS. If discrepancies are discovered through this process (a cache miss) the respective domain administrator is notified of this discrepancy and is requested to update their submission or correct their first-party-set.json file (resolve the cache discrepancy).

It is possible that a site isn't accessible during this process either temporarily or permanently. Regardless, it will become necessary to think about the policies around doing a little garbage collecting and removing an FPS from the github repository. Setting a time limit (say some number of months) for a response from the site administrator to correct the issue might be a reasonable expectation.

@cfredric
Copy link
Collaborator

Thanks for filing this issue, @brownwolf1355! We'll investigate how best to respond/react in cases like that where a mismatch between the .well-known files and the JSON file arises after some period of time.

@brownwolf1355
Copy link
Author

@cfredric, no problem, happy to provide any feedback or discuss.

@dopry
Copy link

dopry commented Aug 9, 2023

What was the reasoning for a first-party-set.json controlled by a 3rd party, rather than using http headers?

@krgovind
Copy link
Collaborator

krgovind commented Aug 9, 2023

What was the reasoning for a first-party-set.json controlled by a 3rd party, rather than using http headers?

@dopry FYI, I responded to your question here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@dopry @cfredric @krgovind @brownwolf1355 and others