Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PSaaS Bug]: Polygon ignition rotations #66

Closed
1 task done
RobBryce opened this issue Mar 28, 2022 · 7 comments
Closed
1 task done

[PSaaS Bug]: Polygon ignition rotations #66

RobBryce opened this issue Mar 28, 2022 · 7 comments
Assignees

Comments

@RobBryce
Copy link
Collaborator

Contact Details

[email protected]

What happened?

Redmine #1249 discussed polygon rotations. In the work described in #33, an update/fix was applied. However, a double-pull/merge on changes to the Math library applied one fix twice during merging, which negated some of these test and despite the work passing my test dataset before release (!), it failed when working with polygon ignitions when actually deployed.

This affects all builds of PSaaS.

Version

(Windows) 2021.12.xx

What component are you seeing the problem on?

PSaaS Binary

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@RobBryce RobBryce added bug Something isn't working W.I.S.E. Triage Issue needs triage labels Mar 28, 2022
@spydmobile spydmobile added Not Billable and removed Triage Issue needs triage labels Mar 28, 2022
@spydmobile
Copy link
Collaborator

@RobBryce confirmed this is done

@spydmobile
Copy link
Collaborator

From Exec: @RobBryce this was already closed, so I will repopen it and you seem to know it already does not work, so lets call this a bug and you need to test becuse you fixed, right?

@spydmobile spydmobile reopened this Oct 7, 2022
@RobBryce
Copy link
Collaborator Author

I marked this as done on April 27. Why was this re-opened?

@spydmobile
Copy link
Collaborator

I marked this as done on April 27. Why was this re-opened?
@RobBryce as it says in the line above it, You marked it done, But it does not work (As you indicated) and since you fixed it, and it does not work, I have reopened it, and said consider it a bug you need to fix/test. Make sense?

@spydmobile
Copy link
Collaborator

@RobBryce this is fire fs003-22, in geojson, and a bunch of fires in the kml, but fs003-22 should be inside the kml.
[sparcs-current_fire_gps.kml.zip](https://github.com/PSaaS-Developers/Project_issues/files/996582
fs003-22.geojson.zip
0/sparcs-current_fire_gps.kml.zip)

@RobBryce
Copy link
Collaborator Author

RobBryce commented Dec 8, 2022

It works with the provided file, thanks @spydmobile .

@spydmobile
Copy link
Collaborator

ok, closing this issue, thanks @RobBryce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants