Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling #491

Open
praseodym opened this issue May 27, 2024 · 0 comments
Open

Improve error handling #491

praseodym opened this issue May 27, 2024 · 0 comments

Comments

@praseodym
Copy link
Member

Events current emails information about exceptions without logging them:

/**
* Method mails about a error.
*
* @param subject of type String
* @param exception of type Exception
*/
@Override
public void sendError(String subject, Exception exception) {
final Context ctx = new Context(new Locale("en"));
ctx.setVariable("exception", exception);
this.sendMailWithContent("[email protected]", subject, this.templateEngine.process("mail/error", ctx));
}

These emails are either broken or not read by the current developers. It would be better to log exceptions to stderr or use Google Cloud Error Reporting (with the GKE integration or Java client library).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant