Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename universities to no longer use a prefix to be compatible with t… #10

Merged
merged 6 commits into from
Oct 25, 2024

Conversation

verwoerd
Copy link
Contributor

…he contest package format

Rename all image files. Update the organizations. Add contest package to the export script. Modify the automation logic to import the contest package using the import-contest script.

…he contest package format

Rename all image files. Update the organizations. Add contest package to the export script. Modify the automation logic to import the contest package using the `import-contest` script.
@verwoerd verwoerd marked this pull request as ready for review October 21, 2024 12:22
Copy link
Contributor

@mpsijm mpsijm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes and the artefacts generated by the GitHub Actions are looking good 😄 I only have some unrelated comments (see below):

@@ -187,4 +187,4 @@ For DOMJudge use the `background_64.zip`.
|---|---|---|---|
| <img src="./others/logos/O-1.svg" width="32" height="32"> | O-1 | OBJECTION! | :heavy_check_mark: |
| <img src="./others/logos/O-2.svg" width="32" height="32"> | O-2 | The Wise Owl | :heavy_check_mark: |
| <img src="./others/logos/O-3.svg" width="32" height="32"> | O-3 | The Wise Owl | :heavy_check_mark: |
| <img src="./others/logos/O-3.svg" width="32" height="32"> | O-3 | Elektrichiens Vakbond | :heavy_check_mark: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just this (also in https://github.com/WISVCH/icpc-logos/blob/contest-package/others/organizations.json#L15)? 😛

Suggested change
| <img src="./others/logos/O-3.svg" width="32" height="32"> | O-3 | Elektrichiens Vakbond | :heavy_check_mark: |
| <img src="./others/logos/O-3.svg" width="32" height="32"> | O-3 | Electrotechnische Vereeniging | :heavy_check_mark: |

universities/organizations.json Show resolved Hide resolved
universities/organizations.json Outdated Show resolved Hide resolved
.github/workflows/make_logos.yaml Outdated Show resolved Hide resolved
Copy link
Member

@maartenweyns maartenweyns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the effort

@verwoerd verwoerd merged commit 3bc35d7 into main Oct 25, 2024
5 checks passed
@verwoerd verwoerd deleted the contest-package branch October 25, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants