-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename universities to no longer use a prefix to be compatible with t… #10
Conversation
…he contest package format Rename all image files. Update the organizations. Add contest package to the export script. Modify the automation logic to import the contest package using the `import-contest` script.
9a0db95
to
48919bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes and the artefacts generated by the GitHub Actions are looking good 😄 I only have some unrelated comments (see below):
@@ -187,4 +187,4 @@ For DOMJudge use the `background_64.zip`. | |||
|---|---|---|---| | |||
| <img src="./others/logos/O-1.svg" width="32" height="32"> | O-1 | OBJECTION! | :heavy_check_mark: | | |||
| <img src="./others/logos/O-2.svg" width="32" height="32"> | O-2 | The Wise Owl | :heavy_check_mark: | | |||
| <img src="./others/logos/O-3.svg" width="32" height="32"> | O-3 | The Wise Owl | :heavy_check_mark: | | |||
| <img src="./others/logos/O-3.svg" width="32" height="32"> | O-3 | Elektrichiens Vakbond | :heavy_check_mark: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just this (also in https://github.com/WISVCH/icpc-logos/blob/contest-package/others/organizations.json#L15)? 😛
| <img src="./others/logos/O-3.svg" width="32" height="32"> | O-3 | Elektrichiens Vakbond | :heavy_check_mark: | | |
| <img src="./others/logos/O-3.svg" width="32" height="32"> | O-3 | Electrotechnische Vereeniging | :heavy_check_mark: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the effort
…he contest package format
Rename all image files. Update the organizations. Add contest package to the export script. Modify the automation logic to import the contest package using the
import-contest
script.