Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low code coverage #163

Open
AntObi opened this issue Sep 4, 2023 · 0 comments
Open

Low code coverage #163

AntObi opened this issue Sep 4, 2023 · 0 comments
Assignees

Comments

@AntObi
Copy link
Collaborator

AntObi commented Sep 4, 2023

The code coverage for SMACT can be reviewed here: https://app.codecov.io/gh/WMD-group/SMACT/tree/master/smact

I would like to bring particular attention to the following modules:

module coverage (%)
smact.distorter 23.53
smact.lattice_parameters 27.93
smact.structure_prediction 62.50
smact.properties 67.31

These modules (the first two in particular) have particularly low coverage. I'll assign increasing the code coverage of the structure_prediction and smact.properties to myself. For the other two modules, I can look to increase the code coverage of them, but I also think that we should have a review of the codebase to see how older functions still integrate with the rest of SMACT.

@AntObi AntObi self-assigned this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant