Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Theme prefixes check #147

Closed
weavertheme opened this issue Mar 16, 2019 · 2 comments
Closed

Theme prefixes check #147

weavertheme opened this issue Mar 16, 2019 · 2 comments
Labels
Status: Duplicate Issue has been asked already. After an issue is marked as duplicate it should be closed. Status: Upstream Issue This is an upstream issue, either in the WPCS, WPThemeReview or PHPCS.

Comments

@weavertheme
Copy link

Variables in theme templates (e.g., 404.php, archive.php, etc.) are incorrectly flagged as errors. Since these files are actually included via get_template_part(), the variables really aren't global in scope as the error implies. Perhaps a comment in the template files could silence this error for these files?
@joyously
Copy link

See WPTT/WPThemeReview#200
and WPTT/WPThemeReview#205

@dingo-d dingo-d added Status: Duplicate Issue has been asked already. After an issue is marked as duplicate it should be closed. Status: Upstream Issue This is an upstream issue, either in the WPCS, WPThemeReview or PHPCS. labels Mar 30, 2019
@dingo-d
Copy link
Member

dingo-d commented Mar 30, 2019

Closing as a duplicate plus upstream. For the globals discussion there is a #103 issue 🙂

@dingo-d dingo-d closed this as completed Mar 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Status: Duplicate Issue has been asked already. After an issue is marked as duplicate it should be closed. Status: Upstream Issue This is an upstream issue, either in the WPCS, WPThemeReview or PHPCS.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@weavertheme @joyously @dingo-d