Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login page doesn't follow system theme...yet #61

Open
0xrxL opened this issue Dec 23, 2024 · 4 comments
Open

Login page doesn't follow system theme...yet #61

0xrxL opened this issue Dec 23, 2024 · 4 comments
Labels
question Further information is requested

Comments

@0xrxL
Copy link

0xrxL commented Dec 23, 2024

After the last failed attempt to fix this issue, I think that only way to achieve this is to build a custom view which interfaces with webview, rather than show the webview page directly.

@WSTxda
Copy link
Owner

WSTxda commented Dec 23, 2024

It works well, but with some caveats. If you open the login screen with the dark theme active, the webview will be dark.

If you switch from light to dark in the webview then the webview will not match that immediately.

About creating a view that interacts with this, I don't think it's worth all the work for something superfluous like a dark theme, and I don't even know if it's possible to interact with Google's login system, my My guess is no, since I've never seen anyone do that.

@WSTxda WSTxda added the question Further information is requested label Dec 23, 2024
@WSTxda
Copy link
Owner

WSTxda commented Dec 23, 2024

And also need to report that this is because of android:configChanges="uiMode|...|..."

But the absence of this flag causes the webview to be completely closed.

@0xrxL
Copy link
Author

0xrxL commented Dec 23, 2024

It works well, but with some caveats. If you open the login screen with the dark theme active, the webview will be dark.

For me login screen appears white only once, after each app restart (manually force close...or system reboot).

It's really weird that you can't reproduce this behaviour anymore. 🤔

@0xrxL
Copy link
Author

0xrxL commented Dec 23, 2024

Apart that (and the unsaved preferences issue), everything is good. I discovered which service was increasing battery consumption on my customized version of YouTube (com.google.chimera), and this version of MicroG replaced the one released by ReVanced 1 year ago. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants