Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STRAMBIO: Member of "read-only" group can see it in "Save in group" list and can "Save" Microscope.json file #36

Open
strambc opened this issue Nov 12, 2022 · 1 comment
Assignees
Labels
bug Something isn't working High

Comments

@strambc
Copy link
Member

strambc commented Nov 12, 2022

Describe the bug
A member of a "read-only" group where Microscope.json files are kept to be made available to all users of a facility or a lab, is able to see the read-only group in the "Save in group:" list and is able to successfully save in the group.

Expected behavior
Desired behavior is that members of a "read-only" group where Microscope.json files are kept to be made available to all users of a facility or a lab, should not be able to have write access to the group to avoid over-writing and messing up a given microscope configuration.

To Reproduce
Steps to reproduce the behavior:

  • Created "UMMS_PMM_BIG_Microscopy" as a "Read-Only" group

image

  • Created "Microscope_User_Test_Group1" as a full-fledged "Read-Write" group.
  • Created "Microscope User1" as a member of both UMMS_PMM_BIG_Microscopy and Microscope_User_Test_Group1 (NOT OWNER).
  • Logged in as Microscope_User1
  • Launch Manage Instrument in MMA
  • Both groups are available as "Load from group" and "Save in group"

image

  • Microscope.json file can apparently be saved in read-only group

image

@strambc strambc added bug Something isn't working High labels Nov 12, 2022
@strambc strambc changed the title STRAMBIO: STRAMBIO: Member of "read-only" group can save Microscope.json file in it Nov 12, 2022
@strambc strambc changed the title STRAMBIO: Member of "read-only" group can save Microscope.json file in it STRAMBIO: Member of "read-only" group can see it in "Save in group" list and can "save Microscope.json file in it Nov 12, 2022
@strambc strambc changed the title STRAMBIO: Member of "read-only" group can see it in "Save in group" list and can "save Microscope.json file in it STRAMBIO: Member of "read-only" group can see it in "Save in group" list and can "Save" Microscope.json file Nov 12, 2022
@strambc
Copy link
Member Author

strambc commented Nov 12, 2022

Note: it is saved in "read-only" group but it is saved under Microscope_User1 MMA_Microscopes. Does not appear to interfere with shared microscopes. But it is very confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working High
Projects
None yet
Development

No branches or pull requests

2 participants