Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: apns and fcm bad token responses are considered as an internal server errors #256

Closed
geekbrother opened this issue Oct 19, 2023 · 0 comments · Fixed by #257
Closed

chore: apns and fcm bad token responses are considered as an internal server errors #256

geekbrother opened this issue Oct 19, 2023 · 0 comments · Fixed by #257
Assignees
@geekbrother
Labels
accepted The issue has been accepted into the project

Comments

@geekbrother
Copy link
Contributor

geekbrother commented Oct 19, 2023 •
edited
Loading

We have a lot of apns(unregistered) HTTP 500 errors. An unregistered device token is not an internal server error and should be distinguished from it. BadDeviceToken error should be used for such cases.
@geekbrother geekbrother self-assigned this Oct 19, 2023
@arein arein added the accepted The issue has been accepted into the project label Oct 19, 2023
@geekbrother geekbrother mentioned this issue Oct 19, 2023
Merged
3 tasks
@geekbrother geekbrother changed the title chore: apns and fcm responses are considered as an internal server errors chore: apns and fcm bad token responses are considered as an internal server errors Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geekbrother geekbrother

Labels
accepted The issue has been accepted into the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: distinguish bad device token errors WalletConnect/push-server
2 participants
@arein @geekbrother