Support TYPO3 13

[nebrot]

We have tested current branch with TYPO3 13.0.0. With this changes it works for our config:

Change version to to ^12.4 || ^13.0

save_and_close/composer.json

Line 25 in 5ce7db1

"typo3/cms-core": "^12.0"

Change version to to 12.4.0-13.4.99

save_and_close/ext_emconf.php

Line 14 in 5ce7db1

'typo3' => '12.4.0-12.4.99',

Perhaps change deprecated constants (only TYPO3 13?!), see: https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.0/Deprecation-101475-IconSizeStringConstants.html#deprecation-101475-icon-size-string-constants

After upgrading to TYPO3 13.1.0 it's not working anymore, perhaps because of new hotkey https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.1/Feature-103529-IntroduceHotkeyForSaveAndClose.html#feature-103529-introduce-hotkey-for-save-and-close ?

[gmartino27]

Also played around and don't found a solution..

Like @nebrot wrote, seems to be related to this:
https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.1/Feature-103529-IntroduceHotkeyForSaveAndClose.html#feature-103529-introduce-hotkey-for-save-and-close

Somebody some ideas how we can bring it to work again for TYPO3 ^13.1.0 ??

[svewap]

Sadly, in my current estimation, it is not possible to implement a save-and-close in vendor/typo3/cms-backend/Classes/Controller/EditDocumentController.php, because when the close parameter is set, in line 467 an exit takes place immediately and saving no longer occurs.
I therefore currently only see the change in overloading and modifying the complete class.
What do you think?
I have pushed my status into the release/v13 branch.

// Close document if a request for closing the document has been sent
if ($this->closeDoc > self::DOCUMENT_CLOSE_MODE_DEFAULT) {
    if ($response = $this->closeDocument($this->closeDoc, $request)) {
        return $response;
    }
}

[nebrot]

I would prefer to not overloading/modifiying the complete class, seems to be huge and could cause other problems after core-updates.

Do you know which specific core change made it impossible to follow the previous path as in v12? Perhaps we should inform the coredevs that this custom solution doesn't work anymore with current 13.3 and probably 13 LTS next week.

There are many discussions after removing the core solution:

• https://forge.typo3.org/issues/87812
• https://forge.typo3.org/issues/95515

[svewap]

Thanks for the feedback and the references to the discussions. I'm surprised that the hotkey is supposed to work.
https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.1/Feature-103529-IntroduceHotkeyForSaveAndClose.html
I'll have to look into it again.