Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-turret units may cause assert spam #3405

Closed
KJeff01 opened this issue Oct 10, 2023 · 1 comment
Closed

Multi-turret units may cause assert spam #3405

KJeff01 opened this issue Oct 10, 2023 · 1 comment

Comments

@KJeff01
Copy link
Member

KJeff01 commented Oct 10, 2023

Describe the bug
Using a Dragon body with 2 turrets can cause assert spam. Specifically this line:

ASSERT_OR_RETURN(, psDroid->psActionTarget[0] != nullptr, "target is NULL while attacking");

It's not exactly new but seeing as these units are somewhat common now I'll make a formal issue for it. If enough units are spamming this assert it could lag the game.

To Reproduce
Steps to reproduce the behavior:

  1. Create a Hydra unit (Dragon with 2 turrets).
  2. Choose a weapon like the Twin Assault Gun.
  3. Choose another weapon like a Vindicator.
  4. Place it with the debug menu near something it could sense but not attack up on a hill (most consistent way to trigger it).
  5. Let the "sensed" object die. Here it will trigger the assert.
  6. If it does happen it may stop if reordering the unit.

Expected behavior
No assert spam.

Your System:

  • Game version: master, several releases.

Additional context
Once this is solved we can also enable the 3 turret ultimate scavenger truck again.

@KJeff01
Copy link
Member Author

KJeff01 commented Nov 12, 2023

Closed with #3503.

@KJeff01 KJeff01 closed this as completed Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant