Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure in ivis_opengl (vk::DispatchLoaderDynamic → vk::detail::DispatchLoaderDynamic) #4121

Closed
AMDmi3 opened this issue Nov 7, 2024 · 5 comments · Fixed by #4122
Labels

Comments

@AMDmi3
Copy link
Contributor

AMDmi3 commented Nov 7, 2024

Describe the bug

Similar build error in many files under lib/ivis_opengl:

/work/usr/ports/games/warzone2100/work/warzone2100/lib/ivis_opengl/3rdparty/vkh_info.hpp:61:112: error: no type named 'DispatchLoaderDynamic' in namespace 'vk'; did you mean 'vk::detail::DispatchLoaderDynamic'?
   61 |         void Output_SurfaceInformation(const vk::PhysicalDevice& physicalDevice, const vk::SurfaceKHR& surface, const vk::DispatchLoaderDynamic& vkDynLoader);
      |                                                                                                                       ^~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                                                                                       vk::detail::DispatchLoaderDynamic
/usr/local/include/vulkan/vulkan.hpp:17275:11: note: 'vk::detail::DispatchLoaderDynamic' declared here

The build is fixed after bulk replacing vk::DispatchLoaderDynamic with vk::detail::DispatchLoaderDynamic.

Your System:

  • OS: FreeBSD 14.1
  • Game version: 4.5.4
  • Vulkan: 1.3.301
@AMDmi3 AMDmi3 added the Bug label Nov 7, 2024
@Monsterovich
Copy link
Contributor

Which version of Vulkan SDK do you have?

@AMDmi3
Copy link
Contributor Author

AMDmi3 commented Nov 7, 2024

  • Vulkan: 1.3.301

@past-due
Copy link
Member

past-due commented Nov 7, 2024

@AMDmi3 Please let me know if the following PR / patch fixes this for you: #4122

@AMDmi3
Copy link
Contributor Author

AMDmi3 commented Nov 7, 2024

@past-due confirmed, it fixes the build

@past-due
Copy link
Member

past-due commented Nov 7, 2024

Thank you for the report - we’ve merged that fix for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants