-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOSS Review #10
Comments
Thanks for your review -- much appreciated 🙏. |
Your comment on controls is very similar to the one raised by the other reviewer in #9 |
Regarding your comment on missing quality dynamics in WNTR: My suggestion would be to relax and rephrase the statement in the paper, e.g. "does not fully integrate (advanced) quality dynamics" or smth. similar. What do you think? |
Right now, the statement of need is only in the paper. However, in efa61b5 I just added it to the landing page of the documentation as well. |
Regarding your comment on contribution guidelines: I did not know about those templates -- thanks a lot for pointing this out to me. I just added issue and pull-request templates and also added a short comment to the README on how to get support. Let me know if you suggest anything else. |
Thanks, that helps clarify the differences. It is also nice to highlight the use of ML throughout the paper, as I think that aspect is a bit understated.
Yes, the leaks in the custom simulator can't be used with the EPANET simulator. I think in your rephrasing I would mention the specific cases you brought up. "does not fully integrate (advanced) quality dynamics with scenarios such as pipe leaks." |
Thanks. That placement looks good, but I haven't seen it update on the actual documentation page. Not sure what triggers the docs to be updated, perhaps it is only on releases? |
These look great, thanks. I'll mark the item as resolved. |
Yes, the documentation is only rebuilt in case of a new release. However, you can check out the documentation of the dev branch on https://epyt-flow.readthedocs.io/en/latest/ -- I just triggered the build of this one manually, so that you can see how it will look like if I make a new release. |
Done in 21b9344 -- I also added a few sentenced highlighting the benefits for AI and ML research |
Does this issue still exist? All tests run successfully on my machine as well as on GitHub (see Actions) -- all tests are run when a commit is pushed. |
Hi @andreArtelt, nice work on the package and paper. Below are some comments for improving both. The only points that I need resolved to complete my review are marked by a ❗, the rest are suggestions you can take or leave now or later.
Functionality
Documentation
Software Paper
The text was updated successfully, but these errors were encountered: