Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for nonunifrom grids #170

Open
biao-geng-me opened this issue Sep 30, 2024 · 3 comments
Open

support for nonunifrom grids #170

biao-geng-me opened this issue Sep 30, 2024 · 3 comments

Comments

@biao-geng-me
Copy link

I read in the paper that WaterLily uses uniform grids. While this is straightforward to setup, it limits the size of the flow domain. The grids are commonly stretched in Cartesian grid + Immersed boundary method type of CFD code.

@biao-geng-me
Copy link
Author

Just to follow up with the issue. Could you share some insights on the choice of uniform grids in WaterLily? Any comment on implementing nonuniform grids in WaterLily? Thank you!

@b-fg
Copy link
Member

b-fg commented Oct 5, 2024

There is some work in progress for reducing flow domains using Biot Savart boundary conditions: BiotSavartBCs.jl, arXiv. There is no short-term plan for non-uniform grids, but PRs are welcomed!

@biao-geng-me
Copy link
Author

Thank you for the information. I did some test cases using the BiotSavartBCs.jl. It seems that its performance is not good. The biot_mom_step! function was from 10 to 100 times slower than the regular mom_step! function. In the end there was little speedup compared to using regular B.C.s and a large domain.

I'm considering working on adding non-uniform grids in WaterLily, but while I have some experience with CFD algorithms, Julia is totally new to me. How much effort do you think it will be to add support for non-uniform grids in WaterLily?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants