Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functions for filters #62

Open
mariuscrsn opened this issue Jun 16, 2023 · 1 comment · Fixed by #63 or #68
Open

Add functions for filters #62

mariuscrsn opened this issue Jun 16, 2023 · 1 comment · Fixed by #63 or #68
Assignees
@RobertoAldea
Labels
enhancement New feature or request

Comments

@mariuscrsn
Copy link
Member

HAL_CAN_result_e HAL_CanFilters(const uint16_t id, const uint16_t mask); :

Regenerative-Battery-Cycler/firmware/Sources/HAL/HAL_CAN/hal_can.h

Line 93 in 6d5da96

HAL_CAN_result_e HAL_CanFilters(const uint16_t id, const uint16_t mask);
Should be
HAL_CAN_result_e HAL_CanAddFilter(const uint16_t id, const uint16_t mask);
@mariuscrsn mariuscrsn added the enhancement New feature or request label Jun 16, 2023
@RobertoAldea
Copy link
Member

Added change and also added function to delete all filters

This was linked to pull requests Jun 21, 2023
Enhancement Feature/hal_can Add/Del filters and return error message #63
Merged
Feature/hal can Fixed error in DelFilters #68
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobertoAldea RobertoAldea

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@mariuscrsn @RobertoAldea