Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement client for Southwest Power Pool #141

Open
r24mille opened this issue Sep 6, 2017 · 2 comments
Open

Implement client for Southwest Power Pool #141

r24mille opened this issue Sep 6, 2017 · 2 comments

Comments

@r24mille
Copy link
Contributor

r24mille commented Sep 6, 2017

The SPPClient is listed as a balancing authority in the client_factory but the class does not implement any of the abstract methods required by BaseClient. Similarly, the test_spp.py class is empty. This dead code is technical debt unless we actually implement a client for Southwest Power Pool.

Their portal at https://marketplace.spp.org/ seems like they should have everything we need. We just need to parse it.

r24mille added a commit to r24mille/pyiso that referenced this issue Sep 8, 2017
This would suggest to our users that the SPP client exists, where currently
spp.py doesn't do anything.
r24mille added a commit to r24mille/pyiso that referenced this issue Sep 8, 2017
We can create new test cases once an SPP client is implemented for WattTime#141.
r24mille added a commit to r24mille/pyiso that referenced this issue Sep 8, 2017
@r24mille
Copy link
Contributor Author

r24mille commented Sep 8, 2017

Upon looking into it, most of the SPP client was lost with rather heavy-handed commit 7ba5aa1 to remove a selenium dependency. Attempt to restore the client without the dependency on selenium. There has to be a lighter-weight way to make the reqests, but all the response parsing functionality should still be valid.

@ajdonnison
Copy link
Contributor

It looks like it was introduced here: fa15a01a with a comment suggesting it probably never worked. I guess we need to do some work on that.

ajdonnison added a commit that referenced this issue Sep 11, 2017
#141 and #130 Removes the 'SPP' option from client_factory(...) until we have something implemented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants