New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloneCreds bug in KERIpy 1.1.0 #681

Open

2byrds opened this issue Feb 16, 2024 · 0 comments

Assignees

Collaborator

2byrds commented Feb 16, 2024

KERIpy 1.1.0 has a bug in the cloneCreds function where it calls cloneTvtAt.
https://github.com/WebOfTrust/keripy/blob/development/src/keri/vdr/viring.py#L405
It should pass the creder.said like grant does:
https://github.com/WebOfTrust/keripy/blob/development/src/keri/app/cli/commands/ipex/grant.py#L109

I will submit a PR that include a unit test to fix it.

This was found during the did:webs upgrade to KERIpy 1.1.0 when doing the designated aliases attestion.

2byrds self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment